Add macro RelationIsNonblockRelation to expand code path like AO/CO #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avamingli
approved these changes
Dec 25, 2023
avamingli
approved these changes
Dec 25, 2023
The builtin types of tables, in kernel, are standard heap table and AO/CO. The custom table AM will fall one of the two code paths. RelationIsAppendOptimized will only choose the builtin AO/CO relations. Some custom table AM, like PAX, will run the same code path as AO/CO. RelationIsNonblockRelation looks replacable by `!RelationIsHeap`, but they have different meanings. RelationIsNonblockRelation expand the relation type to run the code path like AO/CO. `!RelationIsHeap` emphasizes NOT heap relation.
gfphoenix78
force-pushed
the
check-ao
branch
from
6653e9d to
6fc4419
Compare
foreyes
pushed a commit
to foreyes/cloudberrydb
that referenced
this pull request
Jul 8, 2024
…pache#347) The builtin types of tables, in kernel, are standard heap table and AO/CO. The custom table AM will fall one of the two code paths. RelationIsAppendOptimized will only choose the builtin AO/CO relations. Some custom table AM, like PAX, will run the same code path as AO/CO. RelationIsNonblockRelation looks replacable by `!RelationIsHeap`, but they have different meanings. RelationIsNonblockRelation expand the relation type to run the code path like AO/CO. `!RelationIsHeap` emphasizes NOT heap relation. To work with this change, we preserve and oid for pax, to prevent oid clash in the future. Co-authored-by: wuhao <[email protected]> Reviewed-by: Zhang Mingli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin types of tables, in kernel, are standard heap table and AO/CO. The custom table AM will fall one of the two code paths. RelationIsAppendOptimized will only choose the builtin AO/CO relations. Some custom table AM, like PAX, will run the same code path as AO/CO.
RelationIsNonblockRelation looks replacable by
!RelationIsHeap, but they have different meanings. RelationIsNonblockRelation expand the relation type to run the code path like AO/CO.!RelationIsHeapemphasizes NOT heap relation.Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳