Skip to content

Conversation

@jiaqizho
Copy link
Contributor

fix #ISSUE_Number


Change logs

After the pgcrypto module supported sm4, the sm4-128-ofb mode was added in backend/sm4.c

This approach is very unclean. And the implementation of sm4 in pgcrypto is overwritten.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 7f5f30f into apache:main Mar 18, 2024
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
After the pgcrypto module supported sm4, the sm4-128-ofb mode was added in backend/sm4.c
This approach is very unclean. 
And the implementation of sm4 in pgcrypto is overwritten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants