Skip to content

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Jun 26, 2024

fix #ISSUE_Number


Change logs

Current ICW external_fts pipeline is not running with the external-fts version.

Current PR change the package and fix the invalid case fts_segment_reset.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@jiaqizho
Copy link
Contributor Author

let us waitting the ICW ....

@foreyes
Copy link
Contributor

foreyes commented Jun 27, 2024

icw-orca-test failure is unstable test case.

@jiaqizho jiaqizho force-pushed the re-enable-external-fts-icw branch from 9c50796 to 2044248 Compare July 1, 2024 03:21
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Jul 1, 2024

@foreyes
hi, foreyes

IN commit c8271af

image

I am not sure why 2<: <... completed> can create table success?

@jiaqizho jiaqizho force-pushed the re-enable-external-fts-icw branch 2 times, most recently from 3a213ae to 8f58f9e Compare July 5, 2024 06:20
@jiaqizho jiaqizho force-pushed the re-enable-external-fts-icw branch from 8f58f9e to f7b4425 Compare July 5, 2024 06:23
@jiaqizho jiaqizho changed the title [DNM]re-enable the external FTS ICW re-enable the external FTS ICW Jul 8, 2024
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Jul 8, 2024

@my-ship-it PTAL

@jiaqizho jiaqizho requested a review from my-ship-it July 8, 2024 01:49
@my-ship-it my-ship-it merged commit 0265c23 into apache:main Jul 8, 2024
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
Current ICW external_fts pipeline is not running with the external-fts version.
So change the package and fix the invalid case fts_segment_reset.

(cherry picked from commit 0265c23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants