Skip to content

Conversation

@reshke
Copy link
Contributor

@reshke reshke commented Jul 29, 2024

The goal is to achieve consistent coding with https://github.com/cloudberrydb/cloudberrydb/blob/main/src/backend/access/aocs/aocsam.c#L174

Problem tracks down to commit 6b0e52b

No behavior change is expected, just a nit-pick

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@my-ship-it my-ship-it merged commit 057f9d2 into apache:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants