Skip to content

Use syscache lookup in ShouldUseReservedSegno #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfphoenix78 merged 1 commit into from
Aug 7, 2024
Merged

Use syscache lookup in ShouldUseReservedSegno #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions src/backend/access/appendonly/appendonlywriter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include "utils/guc.h"
#include "utils/int8.h"
#include "utils/snapmgr.h"
#include "utils/syscache.h"

#define SEGFILE_CAPACITY_THRESHOLD 0.9

Expand Down Expand Up @@ -329,9 +330,6 @@ ChooseSegnoForCompaction(Relation rel, List *avoid_segnos)
bool
ShouldUseReservedSegno(Relation rel, choose_segno_mode mode)
{
Relation pg_class;
ScanKeyData scankey[1];
SysScanDesc scan;
HeapTuple tuple;
TransactionId xmin;

Expand All @@ -342,21 +340,13 @@ ShouldUseReservedSegno(Relation rel, choose_segno_mode mode)
if (mode != CHOOSE_MODE_WRITE)
return false;

ScanKeyInit(&scankey[0],
Anum_pg_class_oid,
BTEqualStrategyNumber, F_OIDEQ,
ObjectIdGetDatum(RelationGetRelid(rel)));
pg_class = table_open(RelationRelationId, AccessShareLock);
scan = systable_beginscan(pg_class, ClassOidIndexId, true,
NULL, 1, scankey);
tuple = systable_getnext(scan);
if (!tuple)
tuple = SearchSysCache1(RELOID, ObjectIdGetDatum(RelationGetRelid(rel)));
if (!HeapTupleIsValid(tuple))
elog(ERROR, "unable to find relation entry in pg_class for %s",
RelationGetRelationName(rel));

xmin = HeapTupleHeaderGetXmin(tuple->t_data);
systable_endscan(scan);
table_close(pg_class, NoLock);
ReleaseSysCache(tuple);

return TransactionIdIsCurrentTransactionId(xmin);
}
Expand Down