Skip to content

Conversation

@EcaleD
Copy link
Contributor

@EcaleD EcaleD commented Aug 14, 2024

fix #55


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

  • Removed the 'FOR (RANK(number))' option since this was not supported
  • Updated format of the 'ALTER PARTITION' syntax

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

- Removed the 'FOR (RANK(number))' option since this was not supported
- Updated format of the 'ALTER PARTITION' syntax
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii, @EcaleD welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!

@avamingli avamingli added the type: Documentation Improvements or additions to documentation label Aug 14, 2024
@tuhaihe tuhaihe requested review from TomShawn and tuhaihe August 14, 2024 10:44
@tuhaihe
Copy link
Member

tuhaihe commented Aug 14, 2024

Do we need to update the corresponding part on our website? @EcaleD

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EcaleD
Copy link
Contributor Author

EcaleD commented Aug 15, 2024

Do we need to update the corresponding part on our website? @EcaleD

Just checked the doc here, and it looks correct.

@tuhaihe tuhaihe merged commit 26018b9 into apache:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update help command for ALTER TABLE for gpdb partition table

4 participants