Skip to content

[AQUMV] Check relation actually has children when view matching.#577

Merged
my-ship-it merged 2 commits intoapache:mainfrom
avamingli:auqmv_inh
Aug 26, 2024
Merged

[AQUMV] Check relation actually has children when view matching.#577
my-ship-it merged 2 commits intoapache:mainfrom
avamingli:auqmv_inh

Conversation

@avamingli
Copy link
Contributor

We arbitrarily set inh to false with a FIXME before this commit.
It should be corrected later during planning, but it's earlier
as we are doing view matching on parse tree.
Correct inh and skip it if has children.

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

We arbitrarily set inh to false with a FIXME before this commit.
It should be corrected later during planning, but it's earlier
as we are doing view matching on parse tree.
Correct inh and skip it if has children.

Authored-by: Zhang Mingli avamingli@gmail.com
Authored-by: Zhang Mingli avamingli@gmail.com
@my-ship-it my-ship-it merged commit c9b8184 into apache:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants