Forbid inherits tables to store into gp_matview_aux.#587
Merged
my-ship-it merged 1 commit intoapache:mainfrom Aug 26, 2024
Merged
Forbid inherits tables to store into gp_matview_aux.#587my-ship-it merged 1 commit intoapache:mainfrom
my-ship-it merged 1 commit intoapache:mainfrom
Conversation
2 tasks
Inherits tables are not supported for AQUMV. There may be wrong results if we store it in gp_matview_aux. And cause mislead for the view status. Forbid inherits tables when store into gp_matview_aux. Authored-by: Zhang Mingli avamingli@gmail.com
avamingli
force-pushed
the
fix_inherits
branch
from
ebe497f to
a1ac889
Compare
avamingli
changed the title
reshke
approved these changes
Aug 21, 2024
reshke
approved these changes
Aug 22, 2024
my-ship-it
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inherits tables are not supported for AQUMV.
There will be wrong results if we store it in gp_matview_aux. Disable for that.
Fix inherits part issue of #582
Authored-by: Zhang Mingli avamingli@gmail.com
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳