Skip to content

Clarify VMware import conversion storage option #13165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrijapanicsb wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

Clarify VMware import conversion storage option #13165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3852,7 +3852,8 @@
"message.select.nic.network": "Please select a Network for NIC",
"message.select.security.groups": "Please select security group(s) for your new Instance.",
"message.select.start.date.and.time": "Select a start date & time.",
"message.select.temporary.storage.instance.conversion": "(Optional) Select a staging storage for the converted disks",
"message.select.temporary.storage.instance.conversion": "(Optional) Select temporary conversion storage",
"message.select.temporary.storage.instance.conversion.tooltip": "Where virt-v2v temporarily writes converted disks before import to the destination storage pool.",
"message.select.volume.to.continue": "Please select a volume to continue.",
"message.select.vm.to.continue": "Please select an Instance to continue.",
"message.select.zone.description": "Select type of Zone basic/advanced.",
Expand Down
12 changes: 12 additions & 0 deletions ui/src/components/CheckBoxSelectPair.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
:disabled="forExternalNetProvider"
@change="handleCheckChange">
{{ checkBoxLabel }}
<a-tooltip v-if="checkBoxTooltip" :title="checkBoxTooltip">
<info-circle-outlined class="tooltip-icon" />
</a-tooltip>
</a-checkbox>
</a-col>
<a-col :md="24" :lg="layout === 'horizontal' ? 12 : 24">
Expand Down Expand Up @@ -70,6 +73,10 @@ export default {
type: String,
required: true
},
checkBoxTooltip: {
type: String,
default: null
},
defaultCheckBoxValue: {
type: Boolean,
default: false
Expand Down Expand Up @@ -166,4 +173,9 @@ export default {
.ant-list-split .ant-list-item div {
width: 100%;
}

.tooltip-icon {
color: rgba(0,0,0,.45);
margin-left: 2px;
}
</style>
1 change: 1 addition & 0 deletions ui/src/views/tools/ImportUnmanagedInstance.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@
:resourceKey="cluster.id"
:selectOptions="storageOptionsForConversion"
:checkBoxLabel="switches.forceConvertToPool ? $t('message.select.destination.storage.instance.conversion') : $t('message.select.temporary.storage.instance.conversion')"
:checkBoxTooltip="switches.forceConvertToPool ? null : $t('message.select.temporary.storage.instance.conversion.tooltip')"
:defaultCheckBoxValue="switches.forceConvertToPool"
:reversed="false"
@handle-checkselectpair-change="updateSelectedStorageOptionForConversion"
Expand Down
Loading