Merged
Conversation
This was referenced Sep 4, 2020
Member
|
Cordova-Windows deprecation notice was already posted to the repo and also Cordova website reflects it. |
erisu
approved these changes
Aug 2, 2022
20e890e to
9368657
Compare
Member
|
I have rebased this PR. |
Member
|
@brodybits thank you for the PR |
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 46 46
Lines 2123 2123
=======================================
Hits 1874 1874
Misses 249 249 Help us with your feedback. Take ten seconds to tell us how you rate us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Platforms affected
Windows
Motivation and Context
see this discussion in dev@cordova.apache.org
Description
set
"deprecated": truefor Windows insrc/platforms/platformsConfig.jsonTesting
updated:
In a local checkout of
cordova-cli:after adding Windows,
../bin/cordova platform lsgives me the following output:Checklist
I've run the tests to seeall new and existing tests pass - see Travis CI ✅I added automated test coverage as appropriate for this change(platform)if this change only applies to one platform (e.g.(android))