CB-13737 (iOS): fix Splash screen images for iPhone X

[jcesarmobile]

Platforms affected

iOS

What does this PR do?

Takes into account iPhone X sizes for splash screen

What testing has been done on this change?

Tested on iPhone X

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[idoodler]

I can't wait for this PR to be merged!

[jcesarmobile]

@idoodler have you tried? does it work fine for you?

[idoodler]

@jcesarmobile Yes, I can confirm, it is working on my iPhone X (Real device)

[lobo87]

@jcesarmobile was thinking about creating a PR on my own, then saw your solution. We have nearly the same implementation, with the only difference that i split up iphone6Plus and iPhoneX conditions for more readability.

However +1 for your solution!

[jcesarmobile]

Yeah, I did it this way to avoid duplicating the landscape/portrait part, we could probably improve that part entirely.

I will merge it later

[idoodler]

Whats up with the continuous integration test? It looks like the error has nothing to to with this fix.

[jcesarmobile]

@idoodler yeah, the test failure has nothing to do with the PR, they fail for Android. But that wasn't stopping me from merging, I just didn't have time yesterday.
Merging it now and will try to fix the tests later

[iisdan]

Thank you!!!

[DuBistKomisch]

This fixed it for us as well, thanks!