-
Notifications
You must be signed in to change notification settings - Fork 2k
Implementing partition_statistics for EmptyExec (Issue #15873) #16941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
45f710b
init: Implementing partition_statistics for EmptyExec
vim89 45c6a0c
Added a `TreeRender` branch to `DisplayAs` to provide informative dis…
vim89 42409f0
Added a `TreeRender` branch to `DisplayAs` to provide informative dis…
vim89 855a115
lint making it clear cloning the Arc, not the inner data
vim89 368656c
Merge pull request #1 from vim89/emptyexec-partitionstats
vim89 e41b2ac
Merge branch 'apache:main' into main
vim89 897fb38
Merge branch 'apache:main' into main
vim89 325ac3c
Added known statistics values
vim89 d1858a7
Merge pull request #2 from vim89/emptyexec-partitionstats
vim89 2fac6be
Merge branch 'apache:main' into main
vim89 03b074d
Merge branch 'main' into main
vim89 3ec5bed
Merge branch 'main' into main
vim89 95c4314
Merge branch 'main' into main
vim89 60c7f59
Merge branch 'main' into main
vim89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the partition statistics in the dedicated file: https://github.com/apache/datafusion/blob/main/datafusion/core/tests/physical_optimizer/partition_statistics.rs.
It also contains the real exection to check the results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah well, thank you & apologies for oversight.
Let me run integration tests and align column stats for values instead of Absent.