Replace custom merge operator with arrow-rs implementation#19424
Merged
Jefffrey merged 1 commit intoapache:mainfrom Dec 25, 2025
Merged
Replace custom merge operator with arrow-rs implementation#19424Jefffrey merged 1 commit intoapache:mainfrom
Jefffrey merged 1 commit intoapache:mainfrom
Conversation
Jefffrey
approved these changes
Dec 24, 2025
Contributor
|
Thanks @pepijnve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
mergeandmerge_nfromarrow-rsinstead of custom implementations #19423.Rationale for this change
The functions
arrow_select::merge::mergeandarrow_select::merge::merge_nwere first implemented for DataFusion incase.rs. They have since been generalised and moved toarrow-rs. Now that anarrow-rsis available that contains these functions, DataFusion should make use of them.What changes are included in this PR?
mergeandmerge_nfromcase.rsalong with the unit tests for those functionsarrow-rsAre these changes tested?
Covered by existing unit tests and SLTs
Are there any user-facing changes?
No