Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 128 additions & 1 deletion datafusion/expr/src/type_coercion/functions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,10 @@ mod tests {

use super::*;
use arrow::datatypes::Field;
use datafusion_common::{assert_contains, types::logical_binary};
use datafusion_common::{
assert_contains,
types::{logical_binary, logical_int64},
};
use datafusion_expr_common::signature::{Coercion, TypeSignatureClass};

#[test]
Expand Down Expand Up @@ -1360,6 +1363,130 @@ mod tests {
Ok(())
}

#[test]
fn test_coercible_nulls() -> Result<()> {
fn null_input(coercion: Coercion) -> Result<Vec<DataType>> {
data_types(
"field",
&[DataType::Null],
&Signature::coercible(vec![coercion], Volatility::Immutable),
)
}

// Casts Null to Int64 if we use TypeSignatureClass::Native
let output = null_input(Coercion::new_exact(TypeSignatureClass::Native(
logical_int64(),
)))?;
assert_eq!(vec![DataType::Int64], output);

let output = null_input(Coercion::new_implicit(
TypeSignatureClass::Native(logical_int64()),
vec![],
NativeType::Int64,
))?;
assert_eq!(vec![DataType::Int64], output);

// Null gets passed through if we use TypeSignatureClass apart from Native
let output = null_input(Coercion::new_exact(TypeSignatureClass::Integer))?;
assert_eq!(vec![DataType::Null], output);

let output = null_input(Coercion::new_implicit(
TypeSignatureClass::Integer,
vec![],
NativeType::Int64,
))?;
assert_eq!(vec![DataType::Null], output);

Ok(())
}

#[test]
fn test_coercible_dictionary() -> Result<()> {
let dictionary =
DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Int64));
fn dictionary_input(coercion: Coercion) -> Result<Vec<DataType>> {
data_types(
"field",
&[DataType::Dictionary(
Box::new(DataType::Int8),
Box::new(DataType::Int64),
)],
&Signature::coercible(vec![coercion], Volatility::Immutable),
)
}

// Casts Dictionary to Int64 if we use TypeSignatureClass::Native
let output = dictionary_input(Coercion::new_exact(TypeSignatureClass::Native(
logical_int64(),
)))?;
assert_eq!(vec![DataType::Int64], output);

let output = dictionary_input(Coercion::new_implicit(
TypeSignatureClass::Native(logical_int64()),
vec![],
NativeType::Int64,
))?;
assert_eq!(vec![DataType::Int64], output);

// Dictionary gets passed through if we use TypeSignatureClass apart from Native
let output = dictionary_input(Coercion::new_exact(TypeSignatureClass::Integer))?;
assert_eq!(vec![dictionary.clone()], output);

let output = dictionary_input(Coercion::new_implicit(
TypeSignatureClass::Integer,
vec![],
NativeType::Int64,
))?;
assert_eq!(vec![dictionary.clone()], output);

Ok(())
}

#[test]
fn test_coercible_run_end_encoded() -> Result<()> {
let run_end_encoded = DataType::RunEndEncoded(
Field::new("run_ends", DataType::Int16, false).into(),
Field::new("values", DataType::Int64, true).into(),
);
fn run_end_encoded_input(coercion: Coercion) -> Result<Vec<DataType>> {
data_types(
"field",
&[DataType::RunEndEncoded(
Field::new("run_ends", DataType::Int16, false).into(),
Field::new("values", DataType::Int64, true).into(),
)],
&Signature::coercible(vec![coercion], Volatility::Immutable),
)
}

// Casts REE to Int64 if we use TypeSignatureClass::Native
let output = run_end_encoded_input(Coercion::new_exact(
TypeSignatureClass::Native(logical_int64()),
))?;
assert_eq!(vec![DataType::Int64], output);

let output = run_end_encoded_input(Coercion::new_implicit(
TypeSignatureClass::Native(logical_int64()),
vec![],
NativeType::Int64,
))?;
assert_eq!(vec![DataType::Int64], output);

// REE gets passed through if we use TypeSignatureClass apart from Native
let output =
run_end_encoded_input(Coercion::new_exact(TypeSignatureClass::Integer))?;
assert_eq!(vec![run_end_encoded.clone()], output);

let output = run_end_encoded_input(Coercion::new_implicit(
TypeSignatureClass::Integer,
vec![],
NativeType::Int64,
))?;
assert_eq!(vec![run_end_encoded.clone()], output);

Ok(())
}

#[test]
fn test_get_valid_types_coercible_binary() -> Result<()> {
let signature = Signature::coercible(
Expand Down