chore: enforce clippy::allow_attributes for datafusion-ffi crate

[chakkk309]

Which issue does this PR close?

Part of #18881

Rationale for this change

Implement clippy::allow_attributes lint datafusion-ffi crate

What changes are included in this PR?

datafusion-ffi crate modified

Are these changes tested?

Yes

Are there any user-facing changes?

No

[Jefffrey]

It seems surprising to me that we can just remove #[allow(non_camel_case_types)] and clippy doesn't complain 🤔

[chakkk309]

It seems surprising to me that we can just remove #[allow(non_camel_case_types)] and clippy doesn't complain 🤔

Seems like the non_camel_case_types is default allowed in our project 🫨
When we run cargo clippy --all-targets --workspace -- -D warnings only turns existing warnings into errors seems it does not activate new lints.

[Jefffrey]

Thanks @chakkk309

[Jefffrey]

@chakkk309 something interesting is that the CI passes, but my Rust Analyzer still complains about the lint 🤔

I wonder if we should roll this back

Edit: or is it only on my machine? For reference I'm using Helix, would be good to see if others face this issue

[Jefffrey]

@chakkk309 something interesting is that the CI passes, but my Rust Analyzer still complains about the lint 🤔

I wonder if we should roll this back

Edit: or is it only on my machine? For reference I'm using Helix, would be good to see if others face this issue

I'm looking into this more, it seems a bug with how #[repr(C)] and #[expect(non_camel_case_types)] interact; investigating further

[Jefffrey]

Raised PR to rust analyzer: rust-lang/rust-analyzer#21374

We should keep our code as is for now (no need to rollback), since I don't think it's an issue with rustc or clippy, only rust analyzer

[ChayimFriedman2]

FWIW you can disable the rust-analyzer lint (locally, or for this project) by setting rust-analyzer.diagnostics.disabled to ["non_camel_case_types"].

[Jefffrey]

FWIW you can disable the rust-analyzer lint (locally, or for this project) by setting rust-analyzer.diagnostics.disabled to ["non_camel_case_types"].

TIL, thanks!