Minor: compute qualify window expressions only when QUALIFY clause is present#21173
Merged
jonahgao merged 2 commits intoapache:mainfrom Mar 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Does not close but related #608
Rationale for this change
Followup to #20963
@jonahgao had a feedback in #20963 (comment) to try to find qualify only if we are inside QUALIFY block. I did not think it was this minor so thought followup would be better but this is simply moving to if block to prevent unnecessary computation
What changes are included in this PR?
Move
qualify_window_func_exprscomputation inside the QUALIFY blockAre these changes tested?
Covered by existing tests from #20963.
Are there any user-facing changes?
No