[fix](iceberg) fix the iceberg eq-delete filter resize-fill bug. #51253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
yiguolei
reviewed
May 26, 2025
|
|
||
| /// reset the array capacity | ||
| /// fill the new additional elements using the value | ||
| void resize_fill(size_t n, const T& value) { |
Contributor
There was a problem hiding this comment.
please add some ut for resize fill， we should make sure it only reset the additional new element's value
yiguolei
reviewed
May 26, 2025
be/src/vec/common/pod_array.h
Outdated
|
|
||
| /// reset the array capacity | ||
| /// fill all elements using the value | ||
| void reinit(size_t n, const T& value) { |
Contributor
There was a problem hiding this comment.
Do not add this method. Implement this logic at invoking place.
yiguolei
reviewed
May 26, 2025
| _filter = std::make_unique<IColumn::Filter>(rows, 0); | ||
| } else { | ||
| _filter->resize_fill(rows, 0); | ||
| _filter->reinit(rows, 0); |
Contributor
Author
There was a problem hiding this comment.
ok, Use assign function instead
TPC-H: Total hot run time: 33701 ms |
ghkang98
force-pushed
the
iceberg-eqdelete-filter
branch
from
e42dd8f to
b79c533
Compare
TPC-DS: Total hot run time: 192497 ms |
ClickBench: Total hot run time: 29.03 s |
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
ghkang98
force-pushed
the
iceberg-eqdelete-filter
branch
from
b79c533 to
b1e2401
Compare
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
yiguolei
approved these changes
May 27, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 33911 ms |
TPC-DS: Total hot run time: 193364 ms |
ClickBench: Total hot run time: 29.16 s |
morningman
approved these changes
May 27, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2025
) solve the problem of inconsistent filter data in the doris eq-delete scenario Problem Summary: When Doris reads iceberg's data, if there is eq-deleted data, when filtering the data, the filter will have dirty data due to the incorrect use of the resize-fill function, which will eventually cause Doris's data to be filtered incorrectly. [doris-iceberg-eq-delete-bug.pdf](https://github.com/user-attachments/files/20439214/doris-iceberg-eq-delete-bug.pdf)
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2025
) solve the problem of inconsistent filter data in the doris eq-delete scenario Problem Summary: When Doris reads iceberg's data, if there is eq-deleted data, when filtering the data, the filter will have dirty data due to the incorrect use of the resize-fill function, which will eventually cause Doris's data to be filtered incorrectly. [doris-iceberg-eq-delete-bug.pdf](https://github.com/user-attachments/files/20439214/doris-iceberg-eq-delete-bug.pdf)
yiguolei
pushed a commit
that referenced
this pull request
May 28, 2025
…ll bug. #51253 (#51316) Cherry-picked from #51253 Co-authored-by: kang <[email protected]>
dataroaring
pushed a commit
that referenced
this pull request
May 29, 2025
…ll bug. #51253 (#51315) Cherry-picked from #51253 Co-authored-by: kang <[email protected]>
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…che#51253) solve the problem of inconsistent filter data in the doris eq-delete scenario Problem Summary: When Doris reads iceberg's data, if there is eq-deleted data, when filtering the data, the filter will have dirty data due to the incorrect use of the resize-fill function, which will eventually cause Doris's data to be filtered incorrectly. [doris-iceberg-eq-delete-bug.pdf](https://github.com/user-attachments/files/20439214/doris-iceberg-eq-delete-bug.pdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve the problem of inconsistent filter data in the doris eq-delete scenario
Problem Summary:
When Doris reads iceberg's data, if there is eq-deleted data, when filtering the data, the filter will have dirty data due to the incorrect use of the resize-fill function, which will eventually cause Doris's data to be filtered incorrectly.
doris-iceberg-eq-delete-bug.pdf
yes
added a reinit function to reset the size of a data and fill all the data with the new data area
No.