[improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer#51285
Merged
zy-kkk merged 3 commits intoapache:masterfrom May 28, 2025
Merged
[improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer#51285zy-kkk merged 3 commits intoapache:masterfrom
zy-kkk merged 3 commits intoapache:masterfrom
Conversation
Member
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34117 ms |
TPC-DS: Total hot run time: 185743 ms |
ClickBench: Total hot run time: 29.21 s |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33786 ms |
TPC-DS: Total hot run time: 192286 ms |
ClickBench: Total hot run time: 29.08 s |
3944744 to
9c107be
Compare
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33645 ms |
TPC-DS: Total hot run time: 191976 ms |
ClickBench: Total hot run time: 29.33 s |
morningman
approved these changes
May 28, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
hubgeter
approved these changes
May 28, 2025
CalvinKirs
approved these changes
May 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2025
…e in SQLServer (#51285) 1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename 2、For decimal, we should use the unified createDecimalOrStringType method to build the type
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…e in SQLServer (apache#51285) 1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename 2、For decimal, we should use the unified createDecimalOrStringType method to build the type
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Jun 12, 2025
…e in SQLServer (apache#51285) 1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename 2、For decimal, we should use the unified createDecimalOrStringType method to build the type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
1、In SQLServer, if a type is indentity, then the display of its original type may be changed, such as decimal -> decima(), so we get the string from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType method to build the type
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)