-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](iceberg)Fix the thread pool issue used for commit. #51508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 33791 ms |
TPC-DS: Total hot run time: 185994 ms |
ClickBench: Total hot run time: 29.01 s |
FE UT Coverage ReportIncrement line coverage |
|
run feut |
### What problem does this PR solve? Problem Summary: When Iceberg generates a new snapshot, it performs a merge operation based on the previous snapshot. This operation reads manifest files, and the file reading process uses a global thread pool. However, users may have their own authentication information, which requires the use of doAs to ensure context. Therefore, the thread pool provided by Iceberg cannot be used. ### Release note None
### What problem does this PR solve? Problem Summary: When Iceberg generates a new snapshot, it performs a merge operation based on the previous snapshot. This operation reads manifest files, and the file reading process uses a global thread pool. However, users may have their own authentication information, which requires the use of doAs to ensure context. Therefore, the thread pool provided by Iceberg cannot be used. ### Release note None
Problem Summary: When Iceberg generates a new snapshot, it performs a merge operation based on the previous snapshot. This operation reads manifest files, and the file reading process uses a global thread pool. However, users may have their own authentication information, which requires the use of doAs to ensure context. Therefore, the thread pool provided by Iceberg cannot be used. None
…51508 (#52572) bp #51508 --------- Co-authored-by: wuwenchi <[email protected]>
### What problem does this PR solve? Problem Summary: When Iceberg generates a new snapshot, it performs a merge operation based on the previous snapshot. This operation reads manifest files, and the file reading process uses a global thread pool. However, users may have their own authentication information, which requires the use of doAs to ensure context. Therefore, the thread pool provided by Iceberg cannot be used. ### Release note None
…51508 (#51528) Cherry-picked from #51508 --------- Co-authored-by: wuwenchi <[email protected]> Co-authored-by: Mingyu Chen (Rayner) <[email protected]>
### What problem does this PR solve? Problem Summary: When Iceberg generates a new snapshot, it performs a merge operation based on the previous snapshot. This operation reads manifest files, and the file reading process uses a global thread pool. However, users may have their own authentication information, which requires the use of doAs to ensure context. Therefore, the thread pool provided by Iceberg cannot be used. ### Release note None
…51508) (#53155) bp #51508 --------- Co-authored-by: wuwenchi <[email protected]>
What problem does this PR solve?
Problem Summary:
When Iceberg generates a new snapshot, it performs a merge operation based on the previous snapshot. This operation reads manifest files, and the file reading process uses a global thread pool. However, users may have their own authentication information, which requires the use of doAs to ensure context. Therefore, the thread pool provided by Iceberg cannot be used.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)