Skip to content

providing local cache support for service discovery when registry is unavailable #13856 #15873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghostly72 wants to merge 7 commits into
base: 3.3
Choose a base branch
from
Open

providing local cache support for service discovery when registry is unavailable #13856 #15873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2962a8c
support local cache for service discovery when
ghostly72 Dec 14, 2025
db5922d
Format AbstractRegistry codes
zrlw Dec 17, 2025
01ed236
Update log message for loading cached URLs
zrlw Dec 19, 2025
9f7e849
added !isavailable in subscribe method
ghostly72 Dec 22, 2025
32a1246
Merge branch 'local-cache-support' of github.com:ghostly72/dubbo into…
ghostly72 Dec 22, 2025
722ae11
added !isavailable parameter in subscribe method
ghostly72 Dec 22, 2025
4596b75
ran mvn spotless:apply
ghostly72 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dubbo
Open in desktop
Submodule dubbo added at efed26
21 changes: 21 additions & 0 deletions .../dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/AbstractRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,13 @@ public List<URL> lookup(URL url) {
}
}
}
if (result.isEmpty() && localCacheEnabled) {
List<URL> cached = getCacheUrls(url);
if (CollectionUtils.isNotEmpty(cached)) {
logger.info("Using local cache URLs for lookup of " + url.getServiceKey());
result.addAll(cached);
}
}
return result;
}

Expand Down Expand Up @@ -456,6 +463,20 @@ public void subscribe(URL url, NotifyListener listener) {
Set<NotifyListener> listeners =
ConcurrentHashMapUtils.computeIfAbsent(subscribed, url, n -> new ConcurrentHashSet<>());
listeners.add(listener);
if (localCacheEnabled && !isAvailable()) {
try {
List<URL> cached = getCacheUrls(url);
if (CollectionUtils.isNotEmpty(cached)) {
listener.notify(cached);
logger.info("Registry unavailable or not yet ready. Loaded cached URLs for " + url.getServiceKey()
Copy link
Contributor

@zrlw zrlw Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not-empty cached urls means Registry unavailable or not yet ready ?

Copy link
Author

@ghostly72 ghostly72 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if(localCacheEnabled){
            try{
                List<URL> cached=getCacheUrls(url);
                if(CollectionUtils.isNotEmpty(cached)){
                    listener.notify(cached);
                    logger.info("Registry unavailable or not yet ready. Loaded cached URLs for "+url.getServiceKey()+" : "+cached.size());
                }
            }catch(Throwable t){
                logger.warn(INTERNAL_ERROR,"failed to load local cache","","Failed to load chached registry data for "+url,t);
                throw t;
            }
        }

from what i understood, i think cached list being not empty simply refers to some cached urls being available and the functionality checking for the unavailability of registry is taken care of by
if(localcacheenbled)

Copy link
Author

@ghostly72 ghostly72 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and now looking at it i think instead of
if(localCacheEnabled)

it should be
if(localCacheEnabled and !isAvailable()) ?

Copy link
Contributor

@zrlw zrlw Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for me, it might be better than changing the default behavior directly.

Copy link
Author

@ghostly72 ghostly72 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just added the !isavailable parameter as well

+ " : " + cached.size());
}
} catch (Throwable t) {
logger.warn(
INTERNAL_ERROR, "failed to load cached URLs", "", "Failed to load cached URLs for " + url, t);
throw t;
}
}
}

@Override
Expand Down
Loading