Skip to content

FINERACT-2652: Decouple SavingsAccount from injected collaborators#6024

Open
alberto-art3ch wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2652/decouple-savingsaccount-from-injected-collaborators
Open

FINERACT-2652: Decouple SavingsAccount from injected collaborators#6024
alberto-art3ch wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2652/decouple-savingsaccount-from-injected-collaborators

Conversation

@alberto-art3ch

Copy link
Copy Markdown
Contributor

Description

We are removing @transient service fields from SavingsAccount.

The transient SavingsAccountTransactionSummaryWrapper, SavingsHelper and ConfigurationDomainService (previously injected post-hydration via setHelpers) and the accountNumberRequiresAutoGeneration flag are removed. The three stateless collaborators are bundled into a new singleton SavingsContext bean that is passed as a method parameter; the account-number flag is derived at the service layer.

FINERACT-2652

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant