[server] Optimize auto drop partition perfomance#1047
Merged
luoyuxia merged 1 commit intoapache:mainfrom Jul 4, 2025
Merged
Conversation
|
|
Member
|
cc @swuferhong , could you help to review this? |
zcoo
approved these changes
Jun 16, 2025
Contributor
zcoo
left a comment
zcoo
left a comment
There was a problem hiding this comment.
LTGM. Only left a suggestion
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/AutoPartitionManager.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the partition-tracking data structure to improve drop/create performance and add support for tables with multiple partition keys, and updates tests accordingly.
- Switches
partitionsByTablefrom aTreeSet<String>to aTreeMap<String, Set<String>>to group partitions by their key values. - Adds
extractAutoPartitionValueandaddPartitionToPartitionsByTablehelpers and updatesdoAutoPartition,createPartitions, anddropPartitionsto use the new map structure. - Extends
AutoPartitionManagerTestto cover multi-key partition tables and refactorsTestParams/TestParamsBuilderto handle multiple created/dropped partitions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/AutoPartitionManager.java | Refactored partitionsByTable structure and related methods (doAutoPartition, createPartitions, dropPartitions) to support multi-key partitions |
| fluss-server/src/test/java/com/alibaba/fluss/server/coordinator/AutoPartitionManagerTest.java | Updated test harness to add multi-key partition scenarios and replaced single-value fields with arrays in TestParams and TestParamsBuilder |
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/AutoPartitionManager.java
Show resolved
Hide resolved
drr00t
pushed a commit
to drr00t/fluss
that referenced
this pull request
Jul 5, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
polyzos
pushed a commit
to Alibaba-HZY/fluss
that referenced
this pull request
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #864
Brief change log
Tests
API and Format
Documentation