Skip to content

[hotfix] Optimize the error msg when throwing LogOffsetOutOfRangeException #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swuferhong merged 2 commits into from
Jul 15, 2025
Merged

[hotfix] Optimize the error msg when throwing LogOffsetOutOfRangeException #1216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe87cbe
[hotfix] Optimize the error msg when throwing LogOffsetOutOfRangeExce…
swuferhong Jun 26, 2025
7470932
address jark's comments
swuferhong Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetchCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,33 +256,37 @@ private void handleInitializeErrors(
|| error == Errors.STORAGE_EXCEPTION
|| error == Errors.FENCED_LEADER_EPOCH_EXCEPTION) {
LOG.debug(
"Error in fetch for bucket {}: {}:{}", tb, error.exceptionName(), errorMessage);
"Error in fetch for bucket {}: {}:{}",
tb,
error.exceptionName(),
error.exception(errorMessage));
metadataUpdater.checkAndUpdateMetadata(tablePath, tb);
} else if (error == Errors.UNKNOWN_TABLE_OR_BUCKET_EXCEPTION) {
LOG.warn("Received unknown table or bucket error in fetch for bucket {}", tb);
metadataUpdater.checkAndUpdateMetadata(tablePath, tb);
} else if (error == Errors.LOG_OFFSET_OUT_OF_RANGE_EXCEPTION) {
throw new FetchException(
String.format("The fetching offset %s is out of range", fetchOffset),
error.exception());
String.format(
"The fetching offset %s is out of range: %s",
fetchOffset, error.exception(errorMessage)));
} else if (error == Errors.AUTHORIZATION_EXCEPTION) {
throw new AuthorizationException(errorMessage);
} else if (error == Errors.UNKNOWN_SERVER_ERROR) {
LOG.warn(
"Unknown server error while fetching offset {} for bucket {}: {}",
fetchOffset,
tb,
errorMessage);
error.exception(errorMessage));
} else if (error == Errors.CORRUPT_MESSAGE) {
throw new FetchException(
String.format(
"Encountered corrupt message when fetching offset %s for bucket %s: %s",
fetchOffset, tb, errorMessage));
fetchOffset, tb, error.exception(errorMessage)));
} else {
throw new FetchException(
String.format(
"Unexpected error code %s while fetching at offset %s from bucket %s: %s",
error, fetchOffset, tb, errorMessage));
error, fetchOffset, tb, error.exception(errorMessage)));
}
}
}