set up fluss-lake-iceberg module and IcebergLakeStorage#1339
Merged
luoyuxia merged 5 commits intoapache:mainfrom Jul 15, 2025
Merged
set up fluss-lake-iceberg module and IcebergLakeStorage#1339luoyuxia merged 5 commits intoapache:mainfrom
luoyuxia merged 5 commits intoapache:mainfrom
Conversation
MehulBatra
reviewed
Jul 15, 2025
| This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) | ||
|
|
||
| - org.apache.iceberg:iceberg-core:1.9.1 | ||
| - org.apache.httpcomponents:httpclient:4.5.13 |
Contributor
There was a problem hiding this comment.
Hi @cxxwang789 do we need dependency listings for (httpclient, httpcore, jettison, ini4j, jacoco, jdom2) can we remove them and keep only iceberg core? Only iceberg-core:1.9.1, which is actually being bundled
Contributor
Author
There was a problem hiding this comment.
Yeah I realized this. Fixing.
luoyuxia
reviewed
Jul 15, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@cxxwang789 Thanks for the pr. Only left minor comments. Otherwise, LGTM!
|
|
||
| <properties> | ||
| <iceberg.version>1.9.1</iceberg.version> | ||
| <flink.major.version>1.20</flink.major.version> |
Contributor
There was a problem hiding this comment.
We can move flink.major.version and flink.version into the parent module dependence managerment so that paimon and fluss can share with this.
|
|
||
| @Override | ||
| public LakeTieringFactory<?, ?> createLakeTieringFactory() { | ||
| return null; |
Contributor
There was a problem hiding this comment.
throw not support exception instead of return null..
|
|
||
| @Override | ||
| public LakeCatalog createLakeCatalog() { | ||
| return null; |
platinumhamburg
pushed a commit
to platinumhamburg/fluss
that referenced
this pull request
Jul 18, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
polyzos
pushed a commit
to Alibaba-HZY/fluss
that referenced
this pull request
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1328