Skip to content

[FLINK] Support ORC filesystem sink format#12327

Open
zhanglistar wants to merge 13 commits into
apache:mainfrom
zhanglistar:codex/flink-orc-sink-format
Open

[FLINK] Support ORC filesystem sink format#12327
zhanglistar wants to merge 13 commits into
apache:mainfrom
zhanglistar:codex/flink-orc-sink-format

Conversation

@zhanglistar

@zhanglistar zhanglistar commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

Gluten Flink support ORC flilesystem sink format, solves #12203.
Depends on bigo-sg/velox4j#43 and bigo-sg/velox#52.

How was this patch tested?

UT

Was this patch authored or co-authored using generative AI tooling?

Copilot AI review requested due to automatic review settings June 22, 2026 09:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings June 23, 2026 02:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@zhanglistar zhanglistar force-pushed the codex/flink-orc-sink-format branch from b9fe77f to 4e42142 Compare June 23, 2026 03:39
Copilot AI review requested due to automatic review settings June 23, 2026 03:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings June 23, 2026 04:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sessionResource.close();
}
GlutenCloseables.runWithCleanup(
() -> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GlutenCloseables.runWithCleanUp seems to flush the data in memory to filesystem, but these data's offset may not submit to MQ, therefore, if the job failover or restart, the data would be duplicated

'connector' = 'filesystem',
'path' = 'file:///tmp/data/output/bid/',
'format' = 'csv',
'format' = 'orc',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we can add another sql q10_orc to test this? or change format value in NexmarkTest to test this?

Copilot AI review requested due to automatic review settings June 23, 2026 04:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants