Skip to content

Merge pull request #2 from apache/trunk#11

Closed
vinayrpet wants to merge 1 commit intoapache:trunkfrom
vinayrpet:trunk
Closed

Merge pull request #2 from apache/trunk#11
vinayrpet wants to merge 1 commit intoapache:trunkfrom
vinayrpet:trunk

Conversation

@vinayrpet
Copy link
Copy Markdown

Merging latest changes to trunk

Merging latest changes to trunk
@vinayrpet vinayrpet closed this Nov 18, 2014
@vinayrpet vinayrpet reopened this Nov 18, 2014
@vinayrpet vinayrpet closed this Nov 18, 2014
mekasone pushed a commit to mekasone/hadoop that referenced this pull request Feb 19, 2017
Update script to avoid munging marathon.json.
chancez pushed a commit to chancez/hadoop that referenced this pull request Jul 23, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: Anatolie Lupacescu <anatolie.lupacescu@gamesys.com.uk>

Reviewers: Navina Ramesh <navi.trinity@gmail.com>

Closes apache#11 from anatollupacescu/docs-typo-fix
saxenapranav referenced this pull request in saxenapranav/hadoop Aug 1, 2022
passaro added a commit to passaro/hadoop that referenced this pull request Nov 8, 2022
saxenapranav referenced this pull request in saxenapranav/hadoop Apr 5, 2023
Code to set prefix mode based on account type
saxenapranav referenced this pull request in saxenapranav/hadoop Apr 10, 2023
Code to set prefix mode based on account type #11
singer-bin pushed a commit to singer-bin/hadoop that referenced this pull request Dec 19, 2024
…nal argument

Author: Cheng Lian <lian.cs.zju@gmail.com>

Closes apache#11 from liancheng/fix-cli-arg and squashes the following commits:

85a5453 [Cheng Lian] Reverted the dummy change
47ce817 [Cheng Lian] Dummy change to trigger Travis
1c0a244 [Cheng Lian] The `-d` option for `parquet-schema` shouldn't have optional argument
LuciferYang added a commit to LuciferYang/hadoop that referenced this pull request Apr 16, 2026
First two post-RPC-10-gate mechanical migrations. Both use the
template and the 6-step recipe documented in the design spec §6.3
without deviation.

RPC apache#11 — unsetStoragePolicy (PATH_WRITE):
  Equivalent to setStoragePolicy with policyId UNSPECIFIED (0).
  Reuses the pre-resolved-IIP overload of FSDirAttrOp.setStoragePolicy
  added for setStoragePolicy. No new FSDirAttrOp method needed.

RPC apache#12 — setAcl (PATH_WRITE):
  - New FSDirAclOp.setAcl(fsd, pc, iip, aclSpec) pre-resolved-IIP
    overload — same shape as the existing (fsd, pc, src, aclSpec)
    method minus the resolvePath step. checkOwner + unprotectedSetAcl
    + edit log, all under fsd.writeLock.
  - FSNamesystem.setAclPilot — ~17 lines of actual logic, same
    PATH_WRITE shape as the setPermission/setOwner/setTimes family.

Tests (6 new in TestFSNamesystemFGLIIP):
  unsetStoragePolicy:
    - unsetStoragePolicyOnFile — happy path (set then unset)
    - unsetStoragePolicyOnMissingTargetFails — FNE
  setAcl:
    - setAclOnFile — named-user ACL entry persists
    - setAclOnDirectory — default ACL entries persist
    - setAclOnMissingTargetFails — FNE
    - setAclRespectsOwnerCheck — non-owner gets ACE

Both migrations follow the post-gate recipe exactly:
  1. Mode: PATH_WRITE (single-target write, no subtree)
  2. Pre-resolved-IIP overload in FSDirXxxOp (reused for apache#11,
     new for apache#12)
  3. canUsePilotXxx calls canUsePilotPathWrite directly (no
     RPC-specific Phase-A checks needed)
  4. xxxPilot: acquire PATH_WRITE → throw PEM on null target or
     ancestorsAllowMutate=false → delegate to pre-resolved overload
  5. Outer method: standard tryPilot + PilotResult dispatch
  6. Tests: happy/missing/permission cases

Verification:
  mvn test -pl hadoop-hdfs-project/hadoop-hdfs -o \
    -Dtest='TestFSNamesystemFGLIIP'
  => Tests run: 109, Failures: 0, Errors: 0, Skipped: 0

Post-gate RPC counter: 12 RPCs migrated (10 at gate + 2 post-gate).
No design-doc or checklist updates needed — the template handles
these migrations transparently.

Spec: docs/fgl/HDFS-17385-wave4-pilot-design.md §6.3 (post-gate recipe)
Checklist: docs/fgl/rpc-migration-checklist.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant