HDFS-16141. Address permission related issues with File / Directory#3232
Closed
prasad-acit wants to merge 8 commits intoapache:fglfrom
Closed
HDFS-16141. Address permission related issues with File / Directory#3232prasad-acit wants to merge 8 commits intoapache:fglfrom
prasad-acit wants to merge 8 commits intoapache:fglfrom
Conversation
prasad-acit
commented
Jul 25, 2021
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
prasad-acit
force-pushed
the
HDFS-16141
branch
2 times, most recently
from
e713d8a to
1e7f847
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…rtitionedGSet. Contributed by Xing Lin. (apache#3201)
Contributor
Author
shvachko
reviewed
Aug 10, 2021
Contributor
shvachko
left a comment
shvachko
left a comment
There was a problem hiding this comment.
TestFileCreation is still failing for me with
[INFO] Running org.apache.hadoop.hdfs.TestFileCreation
[ERROR] Tests run: 25, Failures: 0, Errors: 1, Skipped: 2, Time elapsed: 93.408 s <<< FAILURE! - in org.apache.hadoop.hdfs.TestFileCreation
[ERROR] testFileCreationNamenodeRestart(org.apache.hadoop.hdfs.TestFileCreation) Time elapsed: 9.975 s <<< ERROR!
org.apache.hadoop.ipc.RemoteException(java.lang.AssertionError): Must hold read Lock: key = range key: [1, 16385]
at org.apache.hadoop.util.PartitionedGSet.getPartition(PartitionedGSet.java:133)
at org.apache.hadoop.hdfs.server.namenode.INodeMap.get(INodeMap.java:268)
at org.apache.hadoop.hdfs.server.namenode.FSDirectory.getInode(FSDirectory.java:1625)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.isFileDeleted(FSNamesystem.java:5752)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3153)
at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.analyzeFileState(FSDirWriteFileOp.java:634)
at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.storeAllocatedBlock(FSDirWriteFileOp.java:238)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:3036)
at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:908)
@prasad-acit do you think we can fix it here?
Contributor
Author
I am not facing this issue with 3.1.1 branch. Some issue related restart scenario, let me take a look. I will update on this. |
Contributor
|
Why 3.1.1 branch? We are using fgl branch here, right? |
Contributor
Author
|
Thanks @shvachko for review & feedback. I have addressed the comments, can you please take a look? |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1 this looks good now. Will commit in a bit |
Contributor
|
@prasad-acit I removed on commit those lines that you commented out. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDFS-16141. Address permission related issues with File / Directory