YARN-11247. Remove unused classes introduced by YARN-9615.#4720
Merged
dineshchitlangia merged 6 commits intoapache:trunkfrom Oct 18, 2022
Merged
YARN-11247. Remove unused classes introduced by YARN-9615.#4720dineshchitlangia merged 6 commits intoapache:trunkfrom
dineshchitlangia merged 6 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@ayushtkn Can you help review this pr? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@dineshchitlangia Can you help review this pr? Thank you very much! |
dineshchitlangia
approved these changes
Oct 18, 2022
Contributor
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 @slfan1989 , thanks for catching this and fixing it.
Contributor
Author
|
@dineshchitlangia Thank you very much for your help reviewing the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA:YARN-11247. Remove unused classes introduced by YARN-9615.
YARN-9615:
adds Metric to RM's dispatcher, but the patch introduces a class without any usage
org.apache.hadoop.yarn.metrics#DisableEventTypeMetrics
I think this class can be removed.