HDFS-17794 Documentation for dfs.datanode.synconclose#8065
Closed
Jimvin wants to merge 9 commits intoapache:trunkfrom
Jimvin:trunk
Closed
HDFS-17794 Documentation for dfs.datanode.synconclose#8065Jimvin wants to merge 9 commits intoapache:trunkfrom Jimvin:trunk
Jimvin wants to merge 9 commits intoapache:trunkfrom
Jimvin:trunk
Conversation
HDFS-17794 Documentation for dfs.datanode.synconclose
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Nov 10, 2025
ayushtkn
reviewed
Nov 15, 2025
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
There is an entry of this conf in TestHdfsConfigFields, since we are adding it here, can we remove it from there?
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tools/TestHdfsConfigFields.java#L81-L82
Contributor
Author
|
Yes, as far as I can see the property |
dlmarion
reviewed
Nov 25, 2025
…t.xml Co-authored-by: Dave Marion <dlmarion@apache.org>
dlmarion
reviewed
Nov 28, 2025
…t.xml Co-authored-by: Dave Marion <dlmarion@apache.org>
…t.xml Co-authored-by: Dave Marion <dlmarion@apache.org>
|
💔 -1 overall
This message was automatically generated. |
dlmarion
reviewed
Dec 1, 2025
Comment on lines
+1786
to
+1794
| If this property is enabled, the datanode will instruct the | ||
| operating system to sync data block files contents to disk when the | ||
| blockfile is closed. This can help data loss in the event of a malfunction such as a power | ||
| failure. | ||
|
|
||
| This has the benefit of ensuring that data is written to disk | ||
| immediately when a block is closed, avoiding the data being held | ||
| solely in the operating system cache. This can help data loss in the event | ||
| of a malfunction such as a power failure. |
Contributor
There was a problem hiding this comment.
My previous suggestions included moving the sentence "This can help data loss in the event of a malfunction such as a power failure." from the second paragraph to the first and possibly removing the second paragraph because at the time it was inaccurate. Now the sentence is duplicated.
Contributor
There was a problem hiding this comment.
Additionally, it's unclear to me whether or not this property has any bearing on erasure encoded files. It might be useful to run that to ground and include that in the property description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HDFS-17794. Documentation for dfs.datanode.synconclose.
The HDFS configuration property dfs.datanode.synconclose is absent from the hdfs-site.xml documentation. This PR adds and entry in hdfs-default.xml for this property along with a description of its purpose.
How was this patch tested?
Documentation only, no additional testing performed.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?