-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19790. Set Minimum Required Maven Version to 3.9.11 #8214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
951ac4b
d0865fb
5c0f23d
6283543
b6da2e3
67a35a8
53e42b4
675da5e
3537761
bf4311a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -5,7 +5,7 @@ Requirements: | |||||||||||
|
|
||||||||||||
| * Unix System | ||||||||||||
| * JDK 17 | ||||||||||||
| * Maven 3.3 or later | ||||||||||||
| * Maven 3.9.9 or later | ||||||||||||
| * Boost 1.86.0 (if compiling native code) | ||||||||||||
| * Protocol Buffers 3.25.5 (if compiling native code) | ||||||||||||
| * CMake 3.19 or newer (if compiling native code) | ||||||||||||
|
|
@@ -63,7 +63,8 @@ Refer to dev-support/docker/Dockerfile): | |||||||||||
| $ sudo apt-get update | ||||||||||||
| $ sudo apt-get -y install openjdk-17-jdk | ||||||||||||
| * Maven | ||||||||||||
| $ sudo apt-get -y install maven | ||||||||||||
| Most package managers do not install required version of Maven i.e. 3.9.9 or later. | ||||||||||||
| Download and Install Maven manually from https://maven.apache.org/install.html | ||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's replace this with the real commands
Suggested change
Oops, I have the wrong memory, the dev container actually uses Maven 3.9.11, not 3.9.9, sorry for the misleading. Could you update the docs to use 3.9.11?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No issues, thanks for checking. |
||||||||||||
| * Native libraries | ||||||||||||
| $ sudo apt-get -y install build-essential autoconf automake libtool cmake zlib1g-dev pkg-config libssl-dev libsasl2-dev | ||||||||||||
| * GCC 9.3.0 | ||||||||||||
|
|
@@ -583,7 +584,7 @@ Requirements: | |||||||||||
|
|
||||||||||||
| * Windows 10 | ||||||||||||
| * JDK 17 | ||||||||||||
| * Maven 3.3 or later (maven.apache.org) | ||||||||||||
| * Maven 3.9.9 or later (maven.apache.org) | ||||||||||||
| * Boost 1.86.0 (boost.org) | ||||||||||||
| * Protocol Buffers 3.25.5 (https://github.com/protocolbuffers/protobuf/tags) | ||||||||||||
| * CMake 3.19 or newer (cmake.org) | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add maven installation commands as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe say "compatible maven version" and then where the version requirement is declared. This is just to remove a place where changes are needed the next time a maven update is mandated