HADOOP-19824: Could not find resource '${repo.root}

[ajfabbri]

• Remove directory-maven-plugin used to compute repo.root.
• Replace uses of that variable with ../ or ../../ according to
  directory structure.
• formatting: Strip trailing whitespace on save.

Description of PR

Fixes running spotbugs with maven -pl , e.g.
mvn -pl hadoop-tools/hadoop-aws spotbugs:spotbugs

How was this patch tested?

mvnd clean
mvnd clean compile -pl hadoop-tools/hadoop-aws -am
mvnd -pl hadoop-tools/hadoop-aws -am  spotbugs:spotbugs

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• [na] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

• [na] The PR includes the phrase "Contains content generated by "
  where is the name of the AI tool used.
• [na] My use of AI contributions follows the ASF legal policy
  https://www.apache.org/legal/generative-tooling.html

[ajfabbri]

One unrelated CI failure in TestYarnNativeServices.testCreateServiceWithPlacementPolicy

[mukund-thakur]

I don't see any issue doing this but I am not an expert in this part of code so I would wait for other reviews.

[ajfabbri]

Thanks for looking @mukund-thakur. I added @slfan1989 since they recently worked on this.

Some context: This PR fixes the small mvn CLI regression introduced as part of #8053. The maven var repo.root is only used by spotbugs to help subprojects find the new top-level exclude file added as part of the spotbugs upgrade. Since the plugin is not working with the -pl option, I just removed it since (1) fewer dependencies is good (2) the cost of changing a path if/when we move a maven subproject is low.

[pan3793]

LGTM, Jenkins failure should be irrelevant.

22:16:26  /opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-8344/yetus-m2/hadoop-trunk-patch-1 -Dsurefire.rerunFailingTestsCount=2 -Pparallel-tests -P!shelltest -Pnative -Drequire.fuse -Drequire.openssl -Drequire.snappy -Drequire.valgrind -Drequire.zstd -Drequire.test.libhadoop -Pyarn-ui clean test -fae > /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-8344/ubuntu-noble/out/patch-unit-hadoop-mapreduce-project.txt 2>&1
00:22:46  Cannot contact hadoop21: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@152a0a34:hadoop21": Remote call on hadoop21 failed. The channel is closing down or has closed down
00:40:08  ERROR: Caught signal TERM. Killing docker container

[roczei]

Hi @ajfabbri

It looks like this commit is causing an error. For example, it's complaining about this in my PR:

#8357

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8357/4/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt

[ERROR] Could not find resource '../../dev-support/findbugs-exclude-global.xml'. -> [Help 1]

Could you please fix it? Thanks!

[ajfabbri]

Could you please fix it? Thanks!
@roczei looking at this now.

[ajfabbri]

PR to fix this change for inherited projects: #8372