-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19859. Speed up GHA jobs by image cache #8451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| name: Image Cache | ||
|
|
||
| # Security: write privileges are safe since this is triggered only by | ||
| # `push` and `workflow_dispatch` (implying user has write access). | ||
| on: | ||
| # Run jobs when a commit is merged | ||
| push: | ||
| branches: | ||
| - 'trunk' | ||
| - 'branch-*' | ||
| paths: | ||
| - 'dev-support/docker/**' | ||
| workflow_dispatch: | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. It is a "trusted" action. (We still are careful to use best practices below, and our CodeQL scanning helps enforce that in the future.) |
||
|
|
||
| jobs: | ||
| build-image-cache-ubuntu_24: | ||
| permissions: | ||
| packages: write | ||
| name: Run | ||
| uses: ./.github/workflows/tmpl_build_image_cache.yml | ||
| with: | ||
| os: ubuntu_24 | ||
| build-image-cache-debian_13: | ||
| permissions: | ||
| packages: write | ||
| name: Run | ||
| uses: ./.github/workflows/tmpl_build_image_cache.yml | ||
| with: | ||
| os: debian_13 | ||
| build-image-cache-rockylinux_8: | ||
| permissions: | ||
| packages: write | ||
| name: Run | ||
| uses: ./.github/workflows/tmpl_build_image_cache.yml | ||
| with: | ||
| os: rockylinux_8 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| name: Build Image Cache | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| os: | ||
| required: false | ||
| type: string | ||
| description: Operating system to create build image cache for. | ||
| default: ubuntu_24 | ||
|
|
||
| # Default to minimal permissions for workflow. | ||
| permissions: | ||
| packages: read | ||
|
|
||
| jobs: | ||
| main: | ||
| name: build-image-cache-${{ inputs.os }}-${{ github.ref_name }} | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| if: github.repository == 'apache/hadoop' | ||
| runs-on: ubuntu-24.04 | ||
| permissions: | ||
| packages: write | ||
| steps: | ||
| - name: Checkout Hadoop repository | ||
| uses: actions/checkout@v6 | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0 | ||
| - name: Login to DockerHub | ||
| uses: docker/login-action@b45d80f862d83dbcd57f89517bcf500b2ab88fb2 # v4.0.0 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Build image cache for ${{ inputs.os }}-${{ github.ref_name }} | ||
| id: docker_build | ||
| uses: docker/build-push-action@d08e5c354a6adb9ed34480a06d141179aa583294 # v7.0.0 | ||
| with: | ||
| context: ./dev-support/docker/ | ||
| file: ./dev-support/docker/Dockerfile_${{ inputs.os }} | ||
| push: true | ||
| tags: ghcr.io/apache/hadoop/gha-build-${{ inputs.os }}-image-cache:${{ github.ref_name }}-static | ||
| cache-from: type=registry,ref=ghcr.io/apache/hadoop/gha-build-${{ inputs.os }}-image-cache:${{ github.ref_name }} | ||
| cache-to: type=registry,ref=ghcr.io/apache/hadoop/gha-build-${{ inputs.os }}-image-cache:${{ github.ref_name }},mode=max | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just getting familiar with this and reading docs. Is this based on the Spark CI workflows?
The locations passed in (
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I basically replicate it from Spark. https://github.com/apache/spark/blob/branch-4.1/.github/workflows/build_infra_images_cache.yml |
||
| - name: Image digest for ${{ inputs.os }}-${{ github.ref_name }} | ||
| run: echo ${{ steps.docker_build.outputs.digest }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Makes sense to rebuild when anything in here changes. In the future we might just publish an image and use it directly instead of always doing a cached build? We can iterate on it though. 👍
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the cache is better.