Skip to content

Gateway service - service structure dummy class #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xyuanlu merged 6 commits into from
Jul 23, 2024
Merged

Gateway service - service structure dummy class #2840

xyuanlu merged 6 commits into from
Jul 23, 2024

Conversation

@xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Jul 19, 2024 •
edited
Loading

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

resolves #2821

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This change continuous add gateway service.

Tests

  • The following tests are written for this issue:
    NA
  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu changed the base branch from master to helix-gateway-service July 19, 2024 06:45
@xyuanlu xyuanlu marked this pull request as ready for review July 19, 2024 06:46
junkaixue
junkaixue reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I said before, do not mix refactoring and change together. Hard to read. Split the PR for move packages out from real change.

@asfgit asfgit force-pushed the helix-gateway-service branch from c9621de to 446f851 Compare July 19, 2024 22:14
@xyuanlu xyuanlu force-pushed the gatewayservice-1 branch from 40f2dfd to dbd2e2d Compare July 22, 2024 20:23
@xyuanlu xyuanlu force-pushed the gatewayservice-1 branch from dbd2e2d to 25af3e4 Compare July 22, 2024 20:54
@xyuanlu xyuanlu force-pushed the gatewayservice-1 branch from 25af3e4 to c7e6be9 Compare July 22, 2024 20:59
junkaixue
junkaixue reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have java doc along with these methods.

junkaixue
junkaixue approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, lgtm with a minor naming thing.

helix-gateway/src/main/java/org/apache/helix/gateway/service/HelixGatewayServiceProcessor.java Outdated
Comment on lines 8 to 10
public boolean sendStateTransitionMessage(String instanceName);

public void pushEventToManager(GatewayServiceManager.GateWayServiceEvent event);
Copy link
Contributor

@junkaixue junkaixue Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent with naming?

send or push.

Copy link
Contributor Author

@xyuanlu xyuanlu Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR. Updated.

@xyuanlu
Copy link
Contributor Author

xyuanlu commented Jul 23, 2024

This PR is ready to be merged, approved by @junkaixue .
Commit message: [Gateway service - service structure dummy class]

@xyuanlu xyuanlu merged commit cf6a202 into apache:helix-gateway-service Jul 23, 2024
asfgit pushed a commit that referenced this pull request Aug 2, 2024
@xyuanlu @junkaixue
Gateway service - service structure dummy class (#2840)
6c3845c 
Gateway service - service structure dummy class
asfgit pushed a commit that referenced this pull request Sep 6, 2024
@xyuanlu
Gateway service - service structure dummy class (#2840)
ad3e513 
Gateway service - service structure dummy class
asfgit pushed a commit that referenced this pull request Sep 8, 2024
@xyuanlu
Gateway service - service structure dummy class (#2840)
bf86a40 
Gateway service - service structure dummy class
asfgit pushed a commit that referenced this pull request Sep 18, 2024
@xyuanlu
Gateway service - service structure dummy class (#2840)
754dd58 
Gateway service - service structure dummy class
asf-gitbox-commits pushed a commit that referenced this pull request Dec 9, 2025
@xyuanlu @junkaixue
Gateway service - service structure dummy class (#2840)
2d619df 
Gateway service - service structure dummy class
junkaixue pushed a commit that referenced this pull request Dec 9, 2025
@xyuanlu @junkaixue
Gateway service - service structure dummy class (#2840)
556129f 
Gateway service - service structure dummy class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junkaixue junkaixue junkaixue approved these changes

Assignees

No one assigned

Labels

CheckedAndApproved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xyuanlu @junkaixue