Skip to content

Conversation

@xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Jul 30, 2024

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2821

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This change add an API to close client connection.
Also test connection event.

Tests

  • The following tests are written for this issue:

TestGatewayServiceConnection

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu force-pushed the gatewayservice-2 branch 4 times, most recently from b542883 to 1194533 Compare July 30, 2024 05:58
@junkaixue
Copy link
Contributor

ready for review?

@xyuanlu xyuanlu marked this pull request as ready for review July 30, 2024 19:15
@xyuanlu xyuanlu force-pushed the gatewayservice-2 branch 2 times, most recently from 0cd572f to 1e8b219 Compare July 31, 2024 18:22
@xyuanlu
Copy link
Contributor Author

xyuanlu commented Jul 31, 2024

This change is ready to be merged approved by @zpinto // thanks!
Commit message:
Add API to close client connection

@xyuanlu xyuanlu force-pushed the gatewayservice-2 branch from c089044 to 2cd9e4b Compare July 31, 2024 23:27
@xyuanlu xyuanlu merged commit b87f2ea into apache:helix-gateway-service Jul 31, 2024
asfgit pushed a commit that referenced this pull request Aug 2, 2024
API to close grpc client stream connection from server side
asfgit pushed a commit that referenced this pull request Sep 6, 2024
API to close grpc client stream connection from server side
asfgit pushed a commit that referenced this pull request Sep 8, 2024
API to close grpc client stream connection from server side
asfgit pushed a commit that referenced this pull request Sep 18, 2024
API to close grpc client stream connection from server side
asf-gitbox-commits pushed a commit that referenced this pull request Dec 9, 2025
API to close grpc client stream connection from server side
junkaixue pushed a commit that referenced this pull request Dec 9, 2025
API to close grpc client stream connection from server side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants