-
Notifications
You must be signed in to change notification settings - Fork 242
Create Gateway service channel factory #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Gateway service channel factory #2883
Conversation
6870f89 to
e1cbc23
Compare
e1cbc23 to
ff57721
Compare
helix-gateway/src/main/java/org/apache/helix/gateway/HelixGatewayMain.java
Outdated
Show resolved
Hide resolved
...gateway/src/main/java/org/apache/helix/gateway/api/constant/GatewayServiceDefaultConfig.java
Outdated
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/channel/GatewayServiceChannelConfig.java
Outdated
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/channel/GatewayServiceChannelConfig.java
Outdated
Show resolved
Hide resolved
...ateway/src/main/java/org/apache/helix/gateway/channel/HelixGatewayServiceChannelFactory.java
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/service/GatewayServiceManager.java
Show resolved
Hide resolved
c9d802a to
f11c5ae
Compare
f11c5ae to
387c212
Compare
7ea0e7b to
2626839
Compare
2626839 to
e7eb6d8
Compare
junkaixue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm. few minor comments.
helix-gateway/src/main/java/org/apache/helix/gateway/HelixGatewayMain.java
Outdated
Show resolved
Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/channel/GatewayServiceChannelConfig.java
Outdated
Show resolved
Hide resolved
...ateway/src/main/java/org/apache/helix/gateway/channel/HelixGatewayServiceChannelFactory.java
Outdated
Show resolved
Hide resolved
...x-gateway/src/main/java/org/apache/helix/gateway/channel/HelixGatewayServiceGrpcService.java
Outdated
Show resolved
Hide resolved
...x-gateway/src/test/java/org/apache/helix/gateway/chanel/GatewayServiceChannelConfigTest.java
Outdated
Show resolved
Hide resolved
junkaixue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor refactor. Good job! lgtm
...ateway/src/main/java/org/apache/helix/gateway/channel/HelixGatewayServiceChannelFactory.java
Show resolved
Hide resolved
|
This pr is ready to be merged. Approved by @junkaixue This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include: -Introduction of GatewayServiceChannelConfig class to manage various channel configurations. |
This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include: -Introduction of GatewayServiceChannelConfig class to manage various channel configurations. -Implementation of a factory pattern (HelixGatewayServiceChannelFactory) for creating appropriate service channels based on the configuration. -The PR also includes various improvements in error handling, logging, and code organization.
This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include: -Introduction of GatewayServiceChannelConfig class to manage various channel configurations. -Implementation of a factory pattern (HelixGatewayServiceChannelFactory) for creating appropriate service channels based on the configuration. -The PR also includes various improvements in error handling, logging, and code organization.
This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include: -Introduction of GatewayServiceChannelConfig class to manage various channel configurations. -Implementation of a factory pattern (HelixGatewayServiceChannelFactory) for creating appropriate service channels based on the configuration. -The PR also includes various improvements in error handling, logging, and code organization.
This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include: -Introduction of GatewayServiceChannelConfig class to manage various channel configurations. -Implementation of a factory pattern (HelixGatewayServiceChannelFactory) for creating appropriate service channels based on the configuration. -The PR also includes various improvements in error handling, logging, and code organization.
This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include: -Introduction of GatewayServiceChannelConfig class to manage various channel configurations. -Implementation of a factory pattern (HelixGatewayServiceChannelFactory) for creating appropriate service channels based on the configuration. -The PR also includes various improvements in error handling, logging, and code organization.
Issues
#2821
Description
This PR introduces a new configuration system for the Helix Gateway service, allowing for more flexible and customizable channel configurations. The main changes include:
GatewayServiceChannelConfigclass to manage various channel configurations.HelixGatewayServiceChannelFactory) for creating appropriate service channels based on the configuration.The PR also includes various improvements in error handling, logging, and code organization.
Tests
The following tests are written for this issue:
GatewayServiceChannelConfigTest: Tests the newGatewayServiceChannelConfigclass and its builder.TestGatewayServiceConnection: Updated to use the new configuration system.TestGatewayServiceManager: Modified to work with the new channel configuration.(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)