-
Notifications
You must be signed in to change notification settings - Fork 242
Gateway - User report their shards' current state instead of state transition message #2892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway - User report their shards' current state instead of state transition message #2892
Conversation
c267b94 to
2300722
Compare
| * @param message the message to send | ||
| */ | ||
| void sendStateTransitionMessage(String instanceName, String currentState, Message message); | ||
| void sendStateTransitionMessage(String instanceName,Message message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the confusing part:
- If you are talking about Helix state transition, why not still have state transition message? We will have target state, right?
- If it is the message from Gateway manager to channel, then let's not call it message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
ba303af to
3132acc
Compare
3132acc to
a58e895
Compare
|
This PR is approved by @junkaixue |
…ansition message (#2892) Gateway - User report their shards' current state instead of state transition message
…ansition message (#2892) Gateway - User report their shards' current state instead of state transition message
…ansition message (#2892) Gateway - User report their shards' current state instead of state transition message
…ansition message (#2892) Gateway - User report their shards' current state instead of state transition message
…ansition message (#2892) Gateway - User report their shards' current state instead of state transition message
Issues
#2821
Description
This pull request (PR) implements changes to the Helix Gateway service, focusing on improving the state transition handling and event processing that aligns to Helix long term goal - retire the concept of message and communicate only target state with helix participant.
The main modifications include:
Updating the protobuf definitions in HelixGatewayService.proto. Removing transition ID for both inbound and outbound message.
Modifying the HelixGatewayServiceChannel interface and its implementations to remove the currentState parameter from the sendStateTransitionMessage method.
Tests
The TestHelixGatewayParticipant class has been updated to reflect the changes in the HelixGatewayParticipant class. Specifically:
The processPendingMessage method now includes a toState parameter and updates the state transition completion logic.
The mock HelixGatewayServiceChannel implementation has been updated to match the new interface.
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)