Skip to content

Only build property key path on construction #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xyuanlu merged 1 commit into from
May 21, 2025
+7 −9
Merged

Only build property key path on construction #3040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions helix-core/src/main/java/org/apache/helix/PropertyKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ public class PropertyKey {
public PropertyType _type;
private final String[] _params;
Class<? extends HelixProperty> _typeClazz;
private String _path;

// if type is CONFIGS, set configScope; otherwise null
ConfigScopeProperty _configScope;
Expand All @@ -110,15 +111,18 @@ public PropertyKey(PropertyType type, Class<? extends HelixProperty> typeClazz,
*/
public PropertyKey(PropertyType type, ConfigScopeProperty configScope,
Class<? extends HelixProperty> typeClazz, String... params) {
_type = type;
if (params == null || params.length == 0 || Arrays.asList(params).contains(null)) {
throw new IllegalArgumentException("params cannot be null");
}

_type = type;
_params = params;
_typeClazz = typeClazz;

_configScope = configScope;
_path = PropertyPathBuilder.getPath(_type, _params[0], Arrays.copyOfRange(_params, 1, _params.length));
if (_path == null) {
LOG.error("Invalid property key with type: {} subKeys: {}", _type, Arrays.toString(_params));
}
}

@Override
Expand Down Expand Up @@ -165,13 +169,7 @@ public boolean equals(Object o) {
* @return absolute path to the property
*/
public String getPath() {
String clusterName = _params[0];
String[] subKeys = Arrays.copyOfRange(_params, 1, _params.length);
String path = PropertyPathBuilder.getPath(_type, clusterName, subKeys);
if (path == null) {
LOG.error("Invalid property key with type:" + _type + "subKeys:" + Arrays.toString(_params));
}
return path;
return _path;
}

/**
Expand Down
Loading