[590] Add Iceberg Glue Catalog Sync implementation#632
Merged
the-other-tim-brown merged 1 commit intoapache:mainfrom Feb 4, 2025
Merged
[590] Add Iceberg Glue Catalog Sync implementation#632the-other-tim-brown merged 1 commit intoapache:mainfrom
the-other-tim-brown merged 1 commit intoapache:mainfrom
Conversation
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalCatalogConfig.java
Show resolved
Hide resolved
xtable-aws/src/main/java/org/apache/xtable/glue/GlueCatalogConfig.java
Outdated
Show resolved
Hide resolved
xtable-aws/src/main/java/org/apache/xtable/glue/GlueSchemaExtractor.java
Outdated
Show resolved
Hide resolved
xtable-aws/src/main/java/org/apache/xtable/glue/table/IcebergGlueCatalogTableBuilder.java
Show resolved
Hide resolved
xtable-aws/src/main/java/org/apache/xtable/glue/GlueCatalogConversionSource.java
Outdated
Show resolved
Hide resolved
xtable-core/src/main/java/org/apache/xtable/exception/CatalogSyncException.java
Show resolved
Hide resolved
xtable-aws/src/main/resources/services/org.apache.xtable.spi.extractor.CatalogConversionSource
Show resolved
Hide resolved
emilie-wang
reviewed
Jan 31, 2025
xtable-aws/src/main/java/org/apache/xtable/glue/GlueSchemaExtractor.java
Outdated
Show resolved
Hide resolved
xtable-aws/src/main/java/org/apache/xtable/glue/GlueSchemaExtractor.java
Outdated
Show resolved
Hide resolved
xtable-api/src/main/java/org/apache/xtable/spi/extractor/CatalogConversionSource.java
Show resolved
Hide resolved
xtable-core/src/main/java/org/apache/xtable/catalog/CatalogConversionFactory.java
Outdated
Show resolved
Hide resolved
vinishjail97
reviewed
Feb 3, 2025
xtable-core/src/main/java/org/apache/xtable/catalog/CatalogUtils.java
Outdated
Show resolved
Hide resolved
xtable-core/src/main/java/org/apache/xtable/catalog/Constants.java
Outdated
Show resolved
Hide resolved
the-other-tim-brown
approved these changes
Feb 4, 2025
Contributor
the-other-tim-brown
left a comment
the-other-tim-brown
left a comment
There was a problem hiding this comment.
Overall things are looking good to me, @vinishjail97 let me know if there are any other concerns from your side that should be addressed before merging.
vinishjail97
approved these changes
Feb 4, 2025
kroushan-nit
force-pushed
the
590-IcebergCatalogSync-v2
branch
from
e44406b to
aee8a5f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#590
Important Read
What is the purpose of the pull request
Added support for syncing a source table to Glue catalog in Iceberg table format
Brief change log
Verify this pull request