Open
Conversation
Contributor
Author
|
@the-other-tim-brown I reviewed #764, that solution would unfortunately not work due to the CSP in place (left details on that PR). We would need to either add the CSS/JS into the repo or update the CSP policy to allow a CDN. Don't know if updating the policy is doable. Importing the JS allows loading multiple fonts later without importing them into the repository. Updating the CSP policy would be the ideal solution, though. I'll check around to see where I can ask for that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
No existing GitHub issue.
Fixes icons not displaying on the landing page due to CSP loading issue.
Current:

Fixed Version:

Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage. Can be verified by visiting a deployed version here: https://azhanl.github.io/incubator-xtable/