[IOTDB-1310] Enable docker, docker-compose and testcontainer for End to end test #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2021 00:09
jixuan1989
force-pushed
the
testcontainer
branch
from
a71e8f6 to
7e8d2cf
Compare
jixuan1989
force-pushed
the
testcontainer
branch
from
7e8d2cf to
c02eb85
Compare
mychaow
reviewed
Apr 22, 2021
| try { | ||
| metaServer = new MetaClusterServer(); | ||
| // preStartCustomize(); | ||
| preStartCustomize(); |
Member
There was a problem hiding this comment.
preStratCustomize is just for debug, should not used in deployment.
icloudsong
approved these changes
Apr 23, 2021
icloudsong
reviewed
Apr 23, 2021
icloudsong
approved these changes
Apr 23, 2021
neuyilan
requested changes
Apr 23, 2021
cluster/src/main/java/org/apache/iotdb/cluster/ClusterMain.java
Outdated
Show resolved
Hide resolved
cluster/src/main/java/org/apache/iotdb/cluster/ClusterMain.java
Outdated
Show resolved
Hide resolved
| # request, the number of nodes picked depends on the number of retries. | ||
| seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007 | ||
| #seed_nodes=127.0.0.1:9003,127.0.0.1:9005,127.0.0.1:9007 | ||
| seed_nodes=127.0.0.1:9003 |
Member
There was a problem hiding this comment.
Is it unfriendly for users to configure only one IP in distributed mode?
Why change the default parameter?
Member
Author
There was a problem hiding this comment.
Actually THIS is "friendly".
What we want:
- let user download the zip (iotdb-cluster.zip)
- unzip the file
- call
start-node.sh - begin to have a try.
If we set 3 ips here, then the process is.... very very difficult for users:
- let user download the zip (iotdb-cluster.zip)
- unzip the file
- copy the file into 3 parts
- modiy
iotdb-cluster.propertiesone by one (very hard, as they have to read the file to know "ah, in the first file, I need modify the parameter as 9003, and modify the rpc port and internal_data port as .... In the second file, I need ...." - call
start-node.sh - begin to have a try.
It is a disaster for fresh man.
If you see other distributed systems, all their default setting is just one node.
Member
There was a problem hiding this comment.
Sure, your consideration is reasonable.
|
SonarCloud Quality Gate failed. |
Member
Author
|
The code coverage is hard to be promoted anymore |
neuyilan
approved these changes
Apr 24, 2021
mzp0514
pushed a commit
to mzp0514/iotdb
that referenced
this pull request
Apr 26, 2021
# This is the 1st commit message: Fix query one sensor in a vector from memtable (apache#3056) Fix query one sensor in a vector from memtable # This is the commit message apache#2: [IOTDB-1310] Enable docker, docker-compose and testcontainer for End to end test (apache#3024) * enable TestCongtainer for E2E test for (singleNode and cluster) * remove duplicated operations in integration-test phase * move spotless:apply to a profile `spotless`, which is enabled by default. Co-authored-by: xiangdong huang <[email protected]> # This is the commit message apache#3: add sink interface # This is the commit message apache#4: 3 new event sinks # This is the commit message apache#5: add ts sink # This is the commit message apache#6: add ts sink # This is the commit message apache#7: add mqtt sink # This is the commit message apache#8: refactor sink module # This is the commit message apache#9: init package sink.manager # This is the commit message apache#10: rename SinkException # This is the commit message apache#11: remove id in config # This is the commit message apache#12: fix doc # This is the commit message apache#13: add test framework # This is the commit message apache#14: add alertmanager sink & test & doc # This is the commit message apache#15: beautify the doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
in the cluster module, set the default number of nodes as 1, and the default replica number as 1.
users can skip to set the value of
internal_ip. Ifinternal_ipis commented, then the hostname of the server will be used rather than127.0.0.1to be used.add a new module
testcontainer. The module will be added if your PC/Mac has installed Docker.the
testcontainermodule will build two docker images:apache/iotdb:maven-developmentandapache/iotdb:cluster-maven-developmentwhen runningmvn pre-integration-testTwo E2E test (end with *IT.java) with TestContainer framework examples are provided, in
testcontainer/src/test/java/, while one is for single node and another is for the cluster with 3 nodes.remove duplicated
verifyphash inintegration-testphase.To disable the
testcontainermodule, use-P !testcontainerin yourmvncommand.In this PR,
spotless:checkis moved to a profile, which is enabled by default. To skip the step (for faster compiling, use-P !spotless).