Skip to content

Conversation

@vlsi
Copy link
Collaborator

@vlsi vlsi commented Mar 19, 2020

Description

This change enables to use of SVG icons for the toolbar.

Motivation and Context

png images do not always look good at HiDPI screens since it requires to generate multiple copies of the image.

In practice, JMeter's toolbar does not provide 2x scaled images, so the pixels are clearly visible.

Screenshots (if appropriate):

Note the icon in the middle

ThemeBeforeAfter
IntelliJ Снимок экрана 2020-03-19 в 23 47 55 Снимок экрана 2020-03-19 в 23 49 38
Solarized dark Снимок экрана 2020-03-19 в 23 48 18 Снимок экрана 2020-03-19 в 23 49 17

@weisJ
Copy link
Contributor

weisJ commented Mar 20, 2020

If the svg icon doesn’t contain any colour, which needs to be resolved at runtime, there is still DarkSVGIcon. Also I think at some point the icons should be overhauled as they are too detailed to work in the scale they are used.

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 20, 2020

Also I think at some point the icons should be overhauled as they are too detailed to work in the scale they are used.

That is true. It should be something like "use this URL for icons 31px+, this URL for 17..31px, and this for 0..16px".

That, however, is a bit different story (==> different PR).

@weisJ
Copy link
Contributor

weisJ commented Mar 20, 2020

That is true. It should be something like "use this URL for icons 31px+, this URL for 17..31px, and this for 0..16px".

Or simply an icon that works in all sizes.

That, however, is a bit different story (==> different PR).

That is true :D

@vlsi vlsi merged commit 662d10d into apache:master Mar 22, 2020
@vlsi
Copy link
Collaborator Author

vlsi commented Mar 24, 2020

I just learned IntelliJ platform requires plugin logos to be in SVG format: https://www.jetbrains.org/intellij/sdk/docs/basics/plugin_structure/plugin_icon_file.html#plugin-logo-file-format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants