Speed up DNSCacheManagerSpec + simplify some code in DNSCacheManager. #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you please clarify why do you mean this speeds up the test? |
Contributor
Author
|
It only does a DNS test/lookup once rather than on each So if you were running this with slow DNS it would timeout once rather than 4 times and save you 1 or many seconds. |
Collaborator
|
Ah, thanks. The change looks good to me. @pmouawad , any comments? |
pmouawad
reviewed
Apr 6, 2020
...ocol/http/src/test/groovy/org/apache/jmeter/protocol/http/control/DNSCacheManagerSpec.groovy
Outdated
Show resolved
Hide resolved
pmouawad
approved these changes
Apr 6, 2020
Co-Authored-By: Vladimir Sitnikov <[email protected]>
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
…apache#580) * Speed up DNSCacheManagerSpec + simplify some code in DNSCacheManager. * Remove printnln
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified and sped up DNSCacheManagerSpec