chore: use testFixtures sourceset instead of depending on all the test classes #5975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
testfixtures
branch
2 times, most recently
from
5a692dd to
15c8bc2
Compare
…t classes This change enables cleaner separation between "actual tests" and "support classes for the tests". For instance, `:src:core` might provide dummy samplers like `ThreadSleep` for testing purposes. `ThreadSleep` would depend on `src/test/main` (since it would `extend AbstractSampler`), and other modules (e.g. tests in `:src:protocols:http`) might need that `ThreadSleep` sampler. It won't be practical to create `core-testkit` modules for every module, so we move those reusable test classes to `testFixtures/...` source set. See https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures
vlsi
force-pushed
the
testfixtures
branch
3 times, most recently
from
eb60144 to
cabc3fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change enables cleaner separation between "actual tests" and "support classes for the tests".
For instance,
:src:coremight provide dummy samplers likeThreadSleepfor testing purposes.ThreadSleepwould depend onsrc/test/main(since it wouldextend AbstractSampler), and other modules (e.g. tests in:src:protocols:http) might need thatThreadSleepsampler.It won't be practical to create
core-testkitmodules for every module, so we move those reusable test classes totestFixtures/...source set.See https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures