fix: encode unicode characters in filenames when sending files in HTTP Sampler #5987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
filename
branch
2 times, most recently
from
830f99f to
3069b20
Compare
vlsi
force-pushed
the
filename
branch
3 times, most recently
from
3069b20 to
ee59a9e
Compare
… the most often used scenario This is a follow-up to apache#678
…P Sampler Fixes apache#4546 Fixes apache#5701 Fixes apache#5982 Fixes apache#5758
|
If I understand well the fix consists in systematically encode file name in UTF8. Wouldn't it be better to encode only if it contains special characters? |
Collaborator
Author
|
It looks like RFC 5987 is not the latest standard: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/network/form_data_encoder.cc;l=162-191;drc=4cd749d0d82138ff31ed3a2bc5d925bb6d83fe16, curl/curl#7789 (comment)
|
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 26, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 26, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 27, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 27, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 27, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 28, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 28, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 28, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
vlsi
added a commit
to vlsi/jmeter
that referenced
this pull request
Jun 29, 2023
In PR 5987 HTTP sampler encoded filenames with percent encoding, however, it should not encode all the characters. Fixes apache#6005 This is a fixup to apache#5987
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use RFC 7578 for encoding filenames when uploading files in HTTP Sampler.
HttpClient4 does not support filename encoding, so we encode it at JMeter side
Motivation and Context
See #4546
How Has This Been Tested?
See
ConversionUtilsTest,HttpSamplerTest