Restore references to boms in the generated pom.xml files #6046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Technically speaking, Maven could use
dependencyManagement / scope=importfor resolution, so we would rather have it for the documentation purposes.At the same time, we put "resolved" versions in the published poms (e.g. to help human consumers, and avoid discrepancies between Maven resolution and Gradle resolution). However, previously we used "runtimeClasspath" for resolving versions for
scope=compile, and it does not work for dependencies which are "compile-only".So the important change here is
fromResolutionOf("runtimeClasspath")->fromResolutionResult()which would default to usecompileClasspathforcompiledependencies.