Merged
Conversation
…r main frame tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return an empty string instead of
nullin#getToolTipText(MouseEvent)for main frame tree.Motivation and Context
Even though the documentation for
JTree#getToolTipText(MouseEvent)says to returnnullif the event isnullthis violates an assumed invariant of the JDK 8 implementation ofToolTipManager.Generally the
ToolTipManagerassumes thatJComponent#getToolTipText(MouseEvent)always returns a non-null value. For components that simply return the value provided byJComponent#setToolTipText(String)this is always the case. Setting the tooltip to a null/non-null value unregisters or registers the component with theToolTipManagerrespectively. For components such as trees where the tooltip text may depend on the current mouse location inside the component this invariant doesn't hold up (because the tree is registered through callingtree.setToolTipText("")).In some scenarios this can cause a
NullPointerExceptionto be thrown inToolTipManager#initiateToolTipspecifically at the following locationThis bug (JDK-6219960) has been fixed in newer version of the JDK by switching to
but this was never backported to JDK 8.
How Has This Been Tested?
Returning
""has the same semantics as returningnulland will result in no tooltip being shown.Types of changes
Checklist: