-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor: migrate existing Groovy tests to Kotlin, remove Groovy compiler from the build pipeline #6212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b590d7 to
38ac9a5
Compare
6c0b393 to
d382e26
Compare
Collaborator
Author
|
For reference, after this PR, |
e6d06f6 to
eaf063d
Compare
…ack history better
…ack history better
…ack history better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Groovy-based tests are somewhat uneasy to maintain as the language is too dynamic for "find usages", "navigate to implementation" to work.
At the same time, Spock/Groovy have issues with support of recent Java (see #6114)
The major part is only a mechanical work, however, there are interesting cases:
ThroughputControllerTest
Groovy-based test lacks structure, and it is hard to tell what is going on.
The same data is much easier to understand in Kotlin: