Skip to content

Conversation

@Timo-1979
Copy link

@Timo-1979 Timo-1979 commented Oct 8, 2020

Description

Add the possibility to load new Security-Provider at the start of JMeter, these Prover could be added and configured via JMeter-Properties.

Motivation and Context

For testing of a service that need special elicpic curves that are available in the BouncyCastleProvider. But to solve the proble it was necessary not only to load this provier, it was requied to load BouncyCastleJsseProvider, too. But the BouncyCastleJsseProvider must be configured to use the BouncyCastleProvider. This was not possible by modify the JVM Setting (java.security). And the creation of a add on that adds the security-providers at test-start was unseccesful.

How Has This Been Tested?

For the two method, for loading the Secrurity-Provider: I've created some JUnit-Test.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly. (Added a section in the properties_reference.xml)

@codecov-io
Copy link

Codecov Report

Merging #629 into master will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #629      +/-   ##
============================================
+ Coverage     55.26%   55.28%   +0.02%     
- Complexity    10078    10084       +6     
============================================
  Files          1038     1038              
  Lines         63853    63883      +30     
  Branches       7232     7235       +3     
============================================
+ Hits          35289    35319      +30     
+ Misses        26064    26063       -1     
- Partials       2500     2501       +1     
Impacted Files Coverage Δ Complexity Δ
...org/apache/jmeter/util/SecurityProviderLoader.java 93.54% <93.54%> (ø) 7.00 <7.00> (?)
...c/core/src/main/java/org/apache/jmeter/JMeter.java 39.97% <100.00%> (+0.07%) 45.00 <0.00> (ø)
...n/java/org/apache/jmeter/reporters/Summariser.java 84.73% <0.00%> (-0.77%) 17.00% <0.00%> (-1.00%)
.../version/org/apache/jmeter/util/JMeterVersion.java
...a/org/apache/jmeter/timers/PoissonRandomTimer.java 78.37% <0.00%> (+5.40%) 10.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc334b0...0cfa2bc. Read the comment docs.

@pmouawad pmouawad merged commit dcf584a into apache:master Oct 25, 2020
@Timo-1979 Timo-1979 deleted the Bug64776 branch October 31, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants