BZ-64800: correcting plugin action components' resource key usages#631
Merged
pmouawad merged 1 commit intoapache:masterfrom Oct 18, 2020
Merged
BZ-64800: correcting plugin action components' resource key usages#631pmouawad merged 1 commit intoapache:masterfrom
pmouawad merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
============================================
- Coverage 55.29% 55.28% -0.02%
+ Complexity 10089 10087 -2
============================================
Files 1038 1038
Lines 63858 63858
Branches 7229 7229
============================================
- Hits 35311 35304 -7
- Misses 26051 26060 +9
+ Partials 2496 2494 -2
Continue to review full report at Codecov.
|
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
In the current version (v5.3), some child menu items under the tools fail to display translated labels when switching to other languages or switching back to English again.
Find more description in the issue ticket: https://bz.apache.org/bugzilla/show_bug.cgi?id=64800
How Has This Been Tested?
Clean build; confirm unit tests succeeded.
And test the GUI menus manually while switching to French or Korean and back to English.
Screenshots (if appropriate):
Now translated menu labels are displayed when switching to French or Korean or back to English, fixing the problem in the screenshot attachment in https://bz.apache.org/bugzilla/show_bug.cgi?id=64800.
Types of changes
Even if the PR has some resource key changes, I don't think it breaks anything because:
Checklist: