Use the argument-free activateOptions() syntax#636
Merged
Conversation
rm5248
reviewed
Apr 24, 2026
| which are ambiguous until the other is also set. | ||
| */ | ||
| #if LOG4CXX_ABI_VERSION <= 15 | ||
| #define LOG4CXX_ACTIVATE_OPTIONS_FORMAL_PARAMETERS helpers::Pool& p |
Contributor
There was a problem hiding this comment.
is the intention to remove these macros for the next ABI version? It's very confusing to see a method with a macro in the parameter list that may or may not be defined.
Contributor
Author
There was a problem hiding this comment.
Yes, when switching to the new ABI, conditional sections can be resolved using my Boost Wave-based program or unifdef and the ABI version-dependant macros (LOG4CXX_ACTIVATE_OPTIONS_FORMAL_PARAMETERS, LOG4CXX_ACTIVATE_OPTIONS_PARAMETER and LOG4CXX_16_VIRTUAL_SPECIFIER) substituted.
…ers to compile existing code
…ers to compile existing code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes all test code that calls activateOptions() and adds a test that demonstrates when an ABI-15-style user-defined appender will work and when it will not (it will generate a compilation error).